public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Johan Hovold <johan@kernel.org>,
	Marek Belisko <marek@goldelico.com>,
	gregkh@linuxfoundation.org, corbet@lwn.net,
	linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, gta04-owner@goldelico.com
Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id
Date: Mon, 30 Mar 2015 12:08:37 +0200	[thread overview]
Message-ID: <20150330100837.GK4046@localhost> (raw)
In-Reply-To: <38A4892E-80CD-4028-87DD-B4AAB4618EC5@goldelico.com>

On Mon, Mar 30, 2015 at 11:32:39AM +0200, Dr. H. Nikolaus Schaller wrote:
> Hi Johan,
> 
> Am 30.03.2015 um 09:45 schrieb Johan Hovold <johan@kernel.org>:
> 
> > On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wrote:
> >> From: "H. Nikolaus Schaller" <hns@goldelico.com>
> >> 
> >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured
> >> the USB interface by mistake and therefore needed to run a different
> >> USB driver than CSC-ACM. It turned out that I need the "usbserial" driver.
> > 
> > CDC-ACM
> 
> oh, thanks. There is always at least one more typo in any document…
> 
> > 
> >> This file is an official description how to use it:
> >> Documentation/usb/usb-serial.txt
> >> 
> >> But it is outdated. The parameters vendor= and product= are no longer
> >> available since ca. 3.12 which means that documentation is lagging behind
> >> quite some time.
> > 
> > This is simply not true. The vendor and module parameters are still
> > there for usbserial (i.e. the generic driver).
> > 
> > Would you mind updating this patch to document the sysfs-method as an
> > alternative instead? Using sysfs is preferred as that functionality can
> > be used with any usb-serial driver and the drivers can also be compiled
> > in.
> 
> Hm. For me it did not work as described and therefore I searched for
> and found the solution cited below, which appears to confirm that it does
> not work any more. Only with these hints to use the /sys approach I
> could make it working immediately.
> 
> Therefore I assumed that the documentation is outdated.
> 
> But it might also be a hidden bug with the parameter passing.
> I had tested on 4.0-rc3.
> 
> I can try a little more but it might be waste of time to find out why the old
> does not work, if there is a preferred method now.

Please do try to figure out if it doesn't work as we have not deprecated
this functionality yet. It should still work.

Johan

  parent reply	other threads:[~2015-03-30 10:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 20:53 [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id Marek Belisko
2015-03-26  9:53 ` Greg KH
2015-03-26 10:41   ` Belisko Marek
2015-03-26 11:34     ` Dr. H. Nikolaus Schaller
2015-03-26 11:42     ` Greg KH
2015-03-28 13:37 ` Marek Belisko
2015-03-30  7:45   ` Johan Hovold
2015-03-30  9:32     ` Dr. H. Nikolaus Schaller
2015-03-30  9:40       ` [Gta04-owner] " Dr. H. Nikolaus Schaller
2015-03-30 10:10         ` Johan Hovold
2015-03-30 10:08       ` Johan Hovold [this message]
2015-04-02 14:25         ` Dr. H. Nikolaus Schaller
2015-04-02 14:34           ` Johan Hovold
2015-04-02 10:12   ` Jonathan Corbet
2015-04-02 10:35     ` Johan Hovold
2015-04-02 10:39       ` Dr. H. Nikolaus Schaller
2015-04-02 12:14       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150330100837.GK4046@localhost \
    --to=johan@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=gta04-owner@goldelico.com \
    --cc=hns@goldelico.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marek@goldelico.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox