From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbbC3KIu (ORCPT ); Mon, 30 Mar 2015 06:08:50 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:35402 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbC3KIr (ORCPT ); Mon, 30 Mar 2015 06:08:47 -0400 Date: Mon, 30 Mar 2015 12:08:37 +0200 From: Johan Hovold To: "Dr. H. Nikolaus Schaller" Cc: Johan Hovold , Marek Belisko , gregkh@linuxfoundation.org, corbet@lwn.net, linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, gta04-owner@goldelico.com Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id Message-ID: <20150330100837.GK4046@localhost> References: <1427316814-22276-1-git-send-email-marek@goldelico.com> <1427549877-7921-1-git-send-email-marek@goldelico.com> <20150330074508.GE4046@localhost> <38A4892E-80CD-4028-87DD-B4AAB4618EC5@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38A4892E-80CD-4028-87DD-B4AAB4618EC5@goldelico.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 11:32:39AM +0200, Dr. H. Nikolaus Schaller wrote: > Hi Johan, > > Am 30.03.2015 um 09:45 schrieb Johan Hovold : > > > On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wrote: > >> From: "H. Nikolaus Schaller" > >> > >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured > >> the USB interface by mistake and therefore needed to run a different > >> USB driver than CSC-ACM. It turned out that I need the "usbserial" driver. > > > > CDC-ACM > > oh, thanks. There is always at least one more typo in any document… > > > > >> This file is an official description how to use it: > >> Documentation/usb/usb-serial.txt > >> > >> But it is outdated. The parameters vendor= and product= are no longer > >> available since ca. 3.12 which means that documentation is lagging behind > >> quite some time. > > > > This is simply not true. The vendor and module parameters are still > > there for usbserial (i.e. the generic driver). > > > > Would you mind updating this patch to document the sysfs-method as an > > alternative instead? Using sysfs is preferred as that functionality can > > be used with any usb-serial driver and the drivers can also be compiled > > in. > > Hm. For me it did not work as described and therefore I searched for > and found the solution cited below, which appears to confirm that it does > not work any more. Only with these hints to use the /sys approach I > could make it working immediately. > > Therefore I assumed that the documentation is outdated. > > But it might also be a hidden bug with the parameter passing. > I had tested on 4.0-rc3. > > I can try a little more but it might be waste of time to find out why the old > does not work, if there is a preferred method now. Please do try to figure out if it doesn't work as we have not deprecated this functionality yet. It should still work. Johan