From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbbC3K1h (ORCPT ); Mon, 30 Mar 2015 06:27:37 -0400 Received: from casper.infradead.org ([85.118.1.10]:60028 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbbC3K1f (ORCPT ); Mon, 30 Mar 2015 06:27:35 -0400 Date: Mon, 30 Mar 2015 12:27:26 +0200 From: Peter Zijlstra To: Viresh Kumar Cc: Ingo Molnar , Thomas Gleixner , Linaro Kernel Mailman List , Linux Kernel Mailing List Subject: Re: [PATCH 0/3] timers: Allocate per-cpu tvec_base's statically Message-ID: <20150330102726.GS23123@twins.programming.kicks-ass.net> References: <20150330081826.GN23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 03:25:36PM +0530, Viresh Kumar wrote: > On 30 March 2015 at 13:48, Peter Zijlstra wrote: > > I did the below on top; I'll sit on these patches for a wee while in the > > hope of the blackfin maintainer explaining his reasons for wrecking > > ____cacheline_aligned. > > Two things I wanted to mention: > > 1.) We may need to drop the patch 2/3 as that breaks build for xtensa and tile. > > kernel/time/timer.c: In function 'init_timers_cpu': > kernel/time/timer.c:1539:1: error: section attribute cannot be > specified for local variables > Can these be fixed somehow ? Hmm, is your xtensa/tile compiler different from your others? But no, I think we need to move it back to global scope. Lemme go do that.