Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

[David Hildenbrand <dahi@linux.vnet.ibm.com>]

> On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote:
> > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to
> > add_callchain_ip") promised "No change in behavior.".
> > 
> > As this commit breaks callchains on s390x (symbols not getting resolved,
> 
> I think it's a generic problem not just s390x
> 
> the x86 archs were safe due to the (al->map == NULL) fallback
> in thread__find_addr_map, where we rerun the lookup for kernel
> maps.. I need to rethink this check :-\
> 
> perhaps s390x did not match the machine__kernel_ip condition?

Most probably yes, in contrast to other archs, we can't really decide based on
the address if it belongs to user or kernel space. So we need the context.

> 
> 
> > observed when profiling the kernel), this statement is wrong. The cpumode
> > must be kept when iterating over all ips, otherwise the default
> > (PERF_RECORD_MISC_USER) will be used by error.
> 
> anyway
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> 

Thanks!

David