From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992AbbC3LZA (ORCPT ); Mon, 30 Mar 2015 07:25:00 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34938 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbbC3LY6 (ORCPT ); Mon, 30 Mar 2015 07:24:58 -0400 Date: Mon, 30 Mar 2015 12:24:53 +0100 From: Lee Jones To: Charles Keepax Cc: sameo@linux.intel.com, broonie@kernel.org, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] mfd: wm5110: Add register patch required for low power sleep Message-ID: <20150330112453.GC9447@x1> References: <1427127589-18297-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1427127589-18297-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427127589-18297-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Mar 2015, Charles Keepax wrote: > Some register settings must be applied before the first time low power > sleep mode is entered on the wm5110 to ensure optimium performance. > These settings require SYSCLK to be enabled whilst they are being > applied. This patch applies the settings using the recently factored out > boot time SYSCLK functionality. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 42 insertions(+), 0 deletions(-) No real problems with this: Acked-by: Lee Jones > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 695c68e..b82b909 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -371,6 +371,38 @@ err: > return err; > } > > +/* > + * Register patch to some of the CODECs internal write sequences > + * to ensure a clean exit from the low power sleep state. > + */ > +static const struct reg_default wm5110_sleep_patch[] = { > + { 0x337A, 0xC100 }, > + { 0x337B, 0x0041 }, > + { 0x3300, 0xA210 }, > + { 0x3301, 0x050C }, > +}; > + > +static inline int wm5110_apply_sleep_patch(struct arizona *arizona) > +{ > + struct arizona_sysclk_state state; > + int err, ret; > + > + ret = arizona_enable_freerun_sysclk(arizona, &state); > + if (ret) > + return ret; > + > + ret = regmap_multi_reg_write_bypassed(arizona->regmap, > + wm5110_sleep_patch, > + ARRAY_SIZE(wm5110_sleep_patch)); > + > + err = arizona_disable_freerun_sysclk(arizona, &state); > + > + if (ret) > + return ret; > + else > + return err; > +} > + > #ifdef CONFIG_PM > static int arizona_runtime_resume(struct device *dev) > { > @@ -940,6 +972,16 @@ int arizona_dev_init(struct arizona *arizona) > goto err_reset; > } > break; > + case WM5110: > + case WM8280: > + ret = wm5110_apply_sleep_patch(arizona); > + if (ret) { > + dev_err(arizona->dev, > + "Failed to apply sleep patch: %d\n", > + ret); > + goto err_reset; > + } > + break; > default: > break; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog