From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] segfault in perf-top -- thread refcnt
Date: Mon, 30 Mar 2015 10:17:24 -0300 [thread overview]
Message-ID: <20150330131724.GC24063@kernel.org> (raw)
In-Reply-To: <20150330102220.GE1413@krava>
Em Mon, Mar 30, 2015 at 12:22:20PM +0200, Jiri Olsa escreveu:
> On Mon, Mar 30, 2015 at 10:07:37AM +0200, Jiri Olsa wrote:
> looks like race among __machine__findnew_thread and thread__put
> over the machine->threads rb_tree insert/removal
>
> is there a reason why thread__put does not erase itself from machine->threads?
IIRC it has to first pass thru:
machine__remove_thread() that will remove the reference count obtained
when inserting the thread on the rbtree and move it to the dead_threads
list, where it will stay until the last reference count obtained when
adding the thread to some hist_entry is finally dropped via
thread__put().
- Arnaldo
prev parent reply other threads:[~2015-03-30 13:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 17:31 [BUG] segfault in perf-top -- thread refcnt David Ahern
2015-03-27 19:51 ` Arnaldo Carvalho de Melo
2015-03-27 20:11 ` Arnaldo Carvalho de Melo
2015-03-27 20:13 ` David Ahern
2015-03-30 8:07 ` Jiri Olsa
2015-03-30 10:22 ` Jiri Olsa
2015-03-30 11:21 ` Jiri Olsa
2015-03-30 11:49 ` Jiri Olsa
2015-03-30 12:48 ` Namhyung Kim
2015-03-30 12:56 ` Jiri Olsa
2015-03-30 13:06 ` Namhyung Kim
2015-03-30 14:02 ` Arnaldo Carvalho de Melo
2015-03-31 0:15 ` Namhyung Kim
2015-03-30 13:07 ` Arnaldo Carvalho de Melo
2015-03-30 13:20 ` Jiri Olsa
2015-03-30 13:59 ` Arnaldo Carvalho de Melo
2015-03-30 14:58 ` Arnaldo Carvalho de Melo
2015-03-30 15:13 ` Arnaldo Carvalho de Melo
2015-03-31 0:27 ` Namhyung Kim
2015-03-31 0:46 ` Arnaldo Carvalho de Melo
2015-03-31 7:21 ` Namhyung Kim
2015-03-30 13:22 ` Arnaldo Carvalho de Melo
2015-03-30 13:09 ` Arnaldo Carvalho de Melo
2015-03-30 13:17 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330131724.GC24063@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).