From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbbC3NkF (ORCPT ); Mon, 30 Mar 2015 09:40:05 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19754 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbbC3NkD (ORCPT ); Mon, 30 Mar 2015 09:40:03 -0400 Date: Mon, 30 Mar 2015 09:39:49 -0400 From: Konrad Rzeszutek Wilk To: "Ouyang Zhaowei (Charles)" Cc: Boris Ostrovsky , David Vrabel , linux-kernel@vger.kernel.org, Dingweiping , Yanqiangjun , Huanglinglong Subject: Re: [PATCH] xen: vcpu_info reinit error after hold/release if VM has multi-cpu Message-ID: <20150330133949.GA28697@l.oracle.com> References: <5519509C.5090804@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5519509C.5090804@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 09:33:16PM +0800, Ouyang Zhaowei (Charles) wrote: > If the VM has multi-cpu the vcpu_info of cpu0 is the member of the structure HYPERVISOR_shared_info, > and the others is not, but after hold/release the VM, the vcpu_info will be reinitialized, What is 'hold/release' ? Pause and suspend? or do you mean suspend was cancelled? > the vcpu_info of all the vcpus will be considered as the member of HYPERVISOR_shared_info. > This will cause the cpu1 and other cpu keep receiving interrupts, and the cpu0 is waiting them to > finish the job. > So we do not reinit the vcpu_info if it's doing hold/release. s/"hold/release"/suspend cancelled/ ? > > Signed-off-by: Charles Ouyang > --- > arch/x86/xen/suspend.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/xen/suspend.c b/arch/x86/xen/suspend.c > index c4df9db..832480c 100644 > --- a/arch/x86/xen/suspend.c > +++ b/arch/x86/xen/suspend.c > @@ -32,7 +32,8 @@ static void xen_hvm_post_suspend(int suspend_cancelled) > { > #ifdef CONFIG_XEN_PVHVM > int cpu; > - xen_hvm_init_shared_info(); > + if (!suspend_cancelled) > + xen_hvm_init_shared_info(); > xen_callback_vector(); > xen_unplug_emulated_devices(); > if (xen_feature(XENFEAT_hvm_safe_pvclock)) { >