From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753134AbbC3PIk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 11:08:40 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:35645 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753095AbbC3PIf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 11:08:35 -0400
Date: Mon, 30 Mar 2015 17:08:30 +0200
From: Thierry Reding <thierry.reding@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Alexandre Courbot <gnurou@gmail.com>, linux-pm@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: tegra: Register governor on module init
Message-ID: <20150330150828.GA18428@ulmo.nvidia.com>
References: <1040887254.91981427710975821.JavaMail.weblogic@epmlwas08a>
 <1427720078-28836-1-git-send-email-tomeu.vizoso@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC"
Content-Disposition: inline
In-Reply-To: <1427720078-28836-1-git-send-email-tomeu.vizoso@collabora.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 30, 2015 at 02:54:38PM +0200, Tomeu Vizoso wrote:
[...]
> +static int __init tegra_devfreq_init(void)
> +{
> +	int ret = 0;
> +
> +	ret = devfreq_add_governor(&tegra_devfreq_governor);
> +	if (ret) {
> +		pr_err("%s: failed to add governor: %d\n", __func__, ret);
> +		return ret;
> +	}
> +
> +	return platform_driver_register(&tegra_devfreq_driver);

Shouldn't you remove the governor on driver registration failure?

Thierry

--wRRV7LY7NUeQGEoC
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVGWbpAAoJEN0jrNd/PrOh1kIQAI90FcZyPJLdpfehccV+ABid
nuVXlO1cMxvEF1Y/jdC3EGb2PXJ3oKWAyttBWYVjGZ48SxBAboAcOY0bAPWep/Sr
fXg9eTkPzcHsxilR2tKxct0XTQSeAq4M3nPyotyt5V9zQWA7rHvH6aXXzNz3pqTg
aIQj2jpKEmL2t17eHDddCVdsW5YTjq2UqnZIwHHAC9GiPBiPJbrDV4LZHmP9Ghfy
vZYClnuScGnC3cFBvgPZK/Ib/YotNaBPscUPipmtlxaJPB1e/avypLLg6LsVNrYT
OBNUQeGiVSZ0vJVwnDCPKCO9hds1SyBXzkr7KpPq1ECc2mdMNdl2gqb/KeOQGgiF
1xvULOkdcnIqouUBMovfbYLoiXZkM7zyu7mE+K76t99Y0jHjrN6eluslCIUrOxlA
mqp0jfp7aoJM+ZURFJoUJrwHYp6djsgtm9gnbbHP233HD8U6UHKC3qerndSCCYnH
4rfBHgW4oDbcD1HEd2GxT8f6gFiLX2H4tJ2PU1S9bov392adwWtG426/xQQXyDT+
T62Ep3Wz9FmtFidkSmjHeiUep7m4eCv+pRFBhudF4rxHffbljniYBG5yK/44ghXQ
jvyGHckYTEaQQq23lRILT4qp/eFlFTchu7wmgyVd49TWUOKKzJ+xw0yNE7C3605r
I31HSQwu+Kjq/JDAjmRX
=j47x
-----END PGP SIGNATURE-----

--wRRV7LY7NUeQGEoC--