From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000AbbC3QfU (ORCPT ); Mon, 30 Mar 2015 12:35:20 -0400 Received: from muru.com ([72.249.23.125]:40793 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbbC3QfR (ORCPT ); Mon, 30 Mar 2015 12:35:17 -0400 Date: Mon, 30 Mar 2015 09:31:09 -0700 From: Tony Lindgren To: Wang Long Cc: keescook@chromium.org, ccross@android.com, anton@enomsg.org, tony.luck@intel.com, linux-kernel@vger.kernel.org, peifeiyue@huawei.com, morgan.wang@huawei.com, sergiu@chromium.org, salyzyn@android.com, anton.vorontsov@linaro.org, marco.stornelli@gmail.com Subject: Re: [PATCH] ramoops: make it possible to change mem_type param. Message-ID: <20150330163108.GH10805@atomide.com> References: <1427447958-42138-1-git-send-email-long.wanglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427447958-42138-1-git-send-email-long.wanglong@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Wang Long [150327 02:43]: > If we set ramoops.mem_type=1 in command line, the current > code can not change mem_type to 1, because it is assigned > to 0 in function ramoops_register_dummy. > > This patch make it possible to change mem_type parameter > in command line. > > Signed-off-by: Wang Long > > --- > fs/pstore/ram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 44a549b..65e0532 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -65,7 +65,7 @@ module_param(mem_size, ulong, 0400); > MODULE_PARM_DESC(mem_size, > "size of reserved RAM used to store oops/panic logs"); > > -static unsigned int mem_type; > +static unsigned int mem_type = 0; > module_param(mem_type, uint, 0600); > MODULE_PARM_DESC(mem_type, > "set to 1 to try to use unbuffered memory (default 0)"); The BSS gets cleared during init so no need to initialize the mem_type separately here and you can drop the change above AFAIK. > @@ -608,7 +608,7 @@ static void ramoops_register_dummy(void) > > dummy_data->mem_size = mem_size; > dummy_data->mem_address = mem_address; > - dummy_data->mem_type = 0; > + dummy_data->mem_type = mem_type; > dummy_data->record_size = record_size; > dummy_data->console_size = ramoops_console_size; > dummy_data->ftrace_size = ramoops_ftrace_size; For this change sounds like a bug. Sorry I was not able to test that with the hardware I have here. Good thing you have been able to verify it with your hardware. If you drop the first part and repost, please also feel free to add: Acked-by: Tony Lindgren