From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbC3RxV (ORCPT ); Mon, 30 Mar 2015 13:53:21 -0400 Received: from mga01.intel.com ([192.55.52.88]:22304 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbbC3RxS (ORCPT ); Mon, 30 Mar 2015 13:53:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,495,1422950400"; d="scan'208";a="672718280" Date: Mon, 30 Mar 2015 23:18:56 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: linux@arm.linux.org.uk, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren , Lee Jones Subject: Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer Message-ID: <20150330174856.GN7192@intel.com> References: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 01:35:53PM +0200, Peter Ujfalusi wrote: > The vd->node is removed from the lists when the transfer started so the > vchan_get_all_descriptors() will not find it. This results memory leak. > > Signed-off-by: Peter Ujfalusi > CC: Stephen Warren > CC: Lee Jones Applied, thanks -- ~Vinod > --- > drivers/dma/bcm2835-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c > index 0723096fb50a..c92d6a70ccf3 100644 > --- a/drivers/dma/bcm2835-dma.c > +++ b/drivers/dma/bcm2835-dma.c > @@ -475,6 +475,7 @@ static int bcm2835_dma_terminate_all(struct dma_chan *chan) > * c->desc is NULL and exit.) > */ > if (c->desc) { > + bcm2835_dma_desc_free(&c->desc->vd); > c->desc = NULL; > bcm2835_dma_abort(c->chan_base); > > -- > 2.3.3 > --