From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbbCaNLN (ORCPT ); Tue, 31 Mar 2015 09:11:13 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54830 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751137AbbCaNLJ (ORCPT ); Tue, 31 Mar 2015 09:11:09 -0400 Date: Mon, 30 Mar 2015 15:10:32 -0700 From: "maxime.ripard" To: Chen-Yu Tsai Cc: "kevin.z.m.zh@gmail.com" , "linux-sunxi@googlegroups.com" , linux-arm-kernel , linux-kernel , Marc Zyngier Subject: Re: [linux-sunxi] Re: [PATCH 2/3] ARM: sun8i: Add SMP support for the Allwinner A23 Message-ID: <20150330221032.GW23664@lukather> References: <1426649042-30547-1-git-send-email-wens@csie.org> <1426649042-30547-3-git-send-email-wens@csie.org> <20150318102939.GP4638@lukather> <2015031912050362587032@gmail.com> <20150319091843.GA4255@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="worL9B4ITIAQZ1FS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --worL9B4ITIAQZ1FS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 25, 2015 at 04:39:08PM -0700, Chen-Yu Tsai wrote: > Hi Maxime, >=20 > On Thu, Mar 19, 2015 at 2:18 AM, maxime.ripard > wrote: > > Hi Kevin, > > > > On Thu, Mar 19, 2015 at 12:05:06PM +0800, kevin.z.m.zh@gmail.com wrote: > >> >> One question I couldn't find any answer to is that does the SMP bit= is > >> >> set in secondary_startup? > >> >> > >> >> I couldn't find where it was set, but it still looks like the right > >> >> thing to do, so I would expect the code to do that. > >> > > >> > I don't see it either. The sun8i code is just the sun6i code with the > >> > power clamps removed. And sun6i secondary_startup was removed some t= ime > >> > ago in commit 1146b600044d ("ARM: sunxi: fix build for THUMB2_KERNEL= "). > >> > > >> > ChenYu > >> > >> The SMP bit should be set in the function of "__v7_ca7mp_setup", which= is located > >> in the file: > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/a= rch/arm/mm/proc-v7.S?id=3Drefs/tags/v4.0-rc4 > >> I'm not sure if this is your discussion. > > > > It is, but I wasn't seeing it called anywhere in the secondary_startup > > code path. > > > > I was expecting a direct call, but it looks like it's a dynamic call, > > with a function-pointer like call, that is indeed run both in the > > kernel entry point and the secondary_startup. > > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/ar= ch/arm/kernel/head.S?id=3Drefs/tags/v4.0-rc4#n389 >=20 > Are we waiting for Marc's input on this? Hmm, no, not really, I just forgot about it :) I'll merge the patches. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --worL9B4ITIAQZ1FS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGcnXAAoJEBx+YmzsjxAgfYEP/ArU+oF7pR89wZkjycEaibgY HeE5sQ2STM40e+O/kJ5YhPICN0cU6j4hw2CqyraKc9TTu+pt8NFOYYCYzxjkVK8Y Jsr6hlC9lub7OeqBTz9cbfjFDdwJnsQ+CK6Rq9LWsIBZan6F8fa9GHk5NoT3NElg z7Nprj59YWY/ZQ41non595/Pi0Kqdq54wjcR/A4S/S+vJosqmUXBJfjhuSpiR8af ksdg9hJfNYWKLJpo8YL6u/IesGDn0pzEPElgPxekEYhsPK60akypnVu39dbNtUVY /dUXHJw9+TnNZ1j5LANUGBfV5hA2K3nytmY351CCjYvm/0npScgr/N96lnsWvPIk 8cbV0ld5HPj9r3QtjuCsTYcRYK+6V7Q21T4E/omR4EH7oMPo0lFHWDMhlU9Elfiu BvsEJZcG6beOGx67ZkQL9Pj1fB9YK7+RQGyD2t+8RHxyQ3Nu3hz1R962PSnRPvYA eu70MOkYMaog4j5bWaoNs3Lotm4KN/fk6lLidDpJGkrkVK/4EJNBzuyOhKiEo+L0 5aINxtM4QgRY1KXdkdV/UO7oc69pfl9btLNZioYPGVgYeh3gFIWUvyJB/EIrk3u7 zu1EAPzd2wONsYgKDuy6slhKxm73DhA0p4/aivGnCEE/j1TA0JNtyfosn848bdFP t6HzonurOjOcKfmeAHcv =I2dr -----END PGP SIGNATURE----- --worL9B4ITIAQZ1FS--