From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754030AbbCaBVd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 21:21:33 -0400
Received: from mail-ie0-f180.google.com ([209.85.223.180]:34630 "EHLO
	mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752066AbbCaBVb convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 21:21:31 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To: Sascha Hauer <s.hauer@pengutronix.de>,
        "Stephen Boyd" <sboyd@codeaurora.org>
From: Michael Turquette <mturquette@linaro.org>
In-Reply-To: <1427737245-4064-3-git-send-email-s.hauer@pengutronix.de>
Cc: "YH Chen" <yh.chen@mediatek.com>, linux-kernel@vger.kernel.org,
        "Henry Chen" <henryc.chen@mediatek.com>,
        linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        "Yingjoe Chen" <Yingjoe.Chen@mediatek.com>,
        "Eddie Huang" <eddie.huang@mediatek.com>,
        linux-arm-kernel@lists.infradead.org,
        "James Liao" <jamesjj.liao@mediatek.com>,
        "Sascha Hauer" <s.hauer@pengutronix.de>
References: <1427737245-4064-1-git-send-email-s.hauer@pengutronix.de>
 <1427737245-4064-3-git-send-email-s.hauer@pengutronix.de>
Message-ID: <20150331012118.7930.69028@quantum>
User-Agent: alot/0.3.5
Subject: Re: [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek
 SoCs.
Date: Mon, 30 Mar 2015 18:21:18 -0700
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Sascha Hauer (2015-03-30 10:40:41)
> +static void mtk_pll_set_rate_regs(struct clk_hw *hw, u32 pcw,
> +               int postdiv)
> +{
> +       struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
> +       u32 con1, pd, val;
> +       int pll_en;
> +
> +       /* set postdiv */
> +       pd = readl(pll->pd_addr);
> +       pd &= ~(0x7 << pll->data->pd_shift);

Hi Sascha,

I found a couple of magic numbers in here. Can we replace these with
some descriptive constant?

Regards,
Mike