Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

Jason Low
2015-04-01T05:17:37Z

On Mon, Mar 30, 2015 at 4:46 PM, Joe Perches <joe@perches.com> wrote:

> * try_wait_for_completion - try to decrement a completion without blocking
> * @x: completion structure
> *
> - * Return: 0 if a decrement cannot be done without blocking
> - * 1 if a decrement succeeded.
> + * Return: true if a decrement cannot be done without blocking
> + * false if a decrement succeeded.

Hi Joe,

The boolean logic was reversed in this comment. The function should be
returning false if a decrement cannot be done without blocking, and
true if a decrement succeeded.