From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbbCaIU6 (ORCPT ); Tue, 31 Mar 2015 04:20:58 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49576 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750962AbbCaIUz (ORCPT ); Tue, 31 Mar 2015 04:20:55 -0400 Date: Tue, 31 Mar 2015 10:20:52 +0200 From: Alexandre Belloni To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , Kukjin Kim , Alessandro Zummo , Chanwoo Choi , "devicetree@vger.kernel.org" , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , rtc-linux@googlegroups.com, Kyungmin Park Subject: Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410 Message-ID: <20150331082052.GI3849@piout.net> References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-2-git-send-email-k.kozlowski@samsung.com> <20150331002709.GF3849@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 31/03/2015 at 08:49:39 +0200, Javier Martinez Canillas wrote : > Hello Alexandre, > > On Tue, Mar 31, 2015 at 2:27 AM, Alexandre Belloni > wrote: > > nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c > > > > Yes but Krzysztof is following the convention used in drivers/rtc/ > which I think is the correct thing to do even when it's different from > what is used all over the kernel. > Having a look at the git history, the first and most used prefix is actually 'rtc:' at some point, this started to change to 'drivers/rtc/'. We should probably start to get back to 'rtc:', like most subsystems. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com