From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbbCaIru (ORCPT ); Tue, 31 Mar 2015 04:47:50 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33483 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbbCaIrr (ORCPT ); Tue, 31 Mar 2015 04:47:47 -0400 Date: Tue, 31 Mar 2015 09:47:41 +0100 From: Lee Jones To: Peter Griffin Cc: Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, balbi@ti.com, devicetree@vger.kernel.org, robherring2@gmail.com Subject: Re: [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Message-ID: <20150331084741.GM9447@x1> References: <1427728632-10846-1-git-send-email-peter.griffin@linaro.org> <1427728632-10846-2-git-send-email-peter.griffin@linaro.org> <551A2D4D.1010601@ti.com> <20150331074027.GH9447@x1> <20150331080154.GA2029@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150331080154.GA2029@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2015, Peter Griffin wrote: > On Tue, 31 Mar 2015, Lee Jones wrote: > > On Tue, 31 Mar 2015, Kishon Vijay Abraham I wrote: > > > > > Hi Patrice, Maxime, > > > > > > On Monday 30 March 2015 08:47 PM, Peter Griffin wrote: > > > >Now there are generic phy type constants declared in phy.h, migrate over to > > > >using them rather than defining our own. This change has been done as one > > > >atomic commit to be bisectable. > > > > > > > >Note: The values of the defines are the same, so there is no ABI breakage > > > >with this patch. > > > > > > > >Signed-off-by: Peter Griffin > > > >Acked-by: Rob Herring > > > >Acked-by: Lee Jones > > > > > > Are you okay for this patch to go via PHY tree? It modifies arch/arm/boot/dts > > > /stih416.dtsi. > > > > These files need to be changed simultaneously in order to prevent > > breakage during bisection and the like. > > That is why it has been authored as one atomic commit. See commit message above. I already know you know why you did it. The comment was for Kishon. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog