From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbbCaIvJ (ORCPT ); Tue, 31 Mar 2015 04:51:09 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35195 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbbCaIvE (ORCPT ); Tue, 31 Mar 2015 04:51:04 -0400 Date: Tue, 31 Mar 2015 09:50:58 +0100 From: Lee Jones To: Ramakrishna Pallala Cc: linux-kernel@vger.kernel.org, MyungJoo Ham , Chanwoo Choi , Samuel Ortiz , Carlo Caione , Jacob Pan Subject: Re: [PATCH v0 1/2] mfd/axp20x: add support for extcon cell Message-ID: <20150331085058.GN9447@x1> References: <1427817838-13775-1-git-send-email-ramakrishna.pallala@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427817838-13775-1-git-send-email-ramakrishna.pallala@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no such thing as v0, yhe first version should be v1. You don't need to write v1 in the subject line either. On Tue, 31 Mar 2015, Ramakrishna Pallala wrote: > This patch adds the mfd cell info for axp288 extcon device. > > Signed-off-by: Ramakrishna Pallala > --- > drivers/mfd/axp20x.c | 28 ++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 5 +++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 0acbe52..30af1a3 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -290,6 +290,29 @@ static struct resource axp288_adc_resources[] = { > }, > }; > > +static struct resource axp288_extcon_resources[] = { > + { > + .start = AXP288_IRQ_VBUS_FALL, > + .end = AXP288_IRQ_VBUS_FALL, > + .flags = IORESOURCE_IRQ, > + }, > + { > + .start = AXP288_IRQ_VBUS_RISE, > + .end = AXP288_IRQ_VBUS_RISE, > + .flags = IORESOURCE_IRQ, > + }, > + { > + .start = AXP288_IRQ_MV_CHNG, > + .end = AXP288_IRQ_MV_CHNG, > + .flags = IORESOURCE_IRQ, > + }, > + { > + .start = AXP288_IRQ_BC_USB_CHNG, > + .end = AXP288_IRQ_BC_USB_CHNG, > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > static struct resource axp288_charger_resources[] = { > { > .start = AXP288_IRQ_OV, > @@ -345,6 +368,11 @@ static struct mfd_cell axp288_cells[] = { > .resources = axp288_adc_resources, > }, > { > + .name = "extcon-axp288", > + .num_resources = ARRAY_SIZE(axp288_extcon_resources), > + .resources = axp288_extcon_resources, > + }, > + { > .name = "axp288_charger", > .num_resources = ARRAY_SIZE(axp288_charger_resources), > .resources = axp288_charger_resources, > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index dfabd6d..4ed8071 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { > int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; > }; > > +struct axp288_extcon_pdata { > + /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */ > + struct gpio_desc *gpio_mux_cntl; > +}; > + What does this have to do with this patch? > #endif /* __LINUX_MFD_AXP20X_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog