From: Joerg Roedel <joro@8bytes.org>
To: "Wu, Feng" <feng.wu@intel.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts
Date: Tue, 31 Mar 2015 17:16:43 +0200 [thread overview]
Message-ID: <20150331151643.GF22683@8bytes.org> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F00245824F@SHSMSX104.ccr.corp.intel.com>
On Tue, Mar 24, 2015 at 02:32:01AM +0000, Wu, Feng wrote:
> > I think it is better to put this as a union into struct irte. It saves
> > memory and unnecessary casting in later patches.
>
> Thanks for the comments!
Thinking more about this, I think its probably fine to keep the two
versions of the irte seperate like in this patch-set. It allows to
update the non-posted irte when the posted irte is active at the moment
and makes the transition between both irte variants easier.
But what I still don't like is the type casting necessary when calling
modify_irte(). Can you abstract this and put the decission whether irte
or irte_pi is set active into modify_irte? It required to change the
interface of modify_irte, but that should be easy.
Joerg
next prev parent reply other threads:[~2015-03-31 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 8:06 [v4 0/8] Add VT-d Posted-Interrupts support - IOMMU part Feng Wu
2015-02-02 8:06 ` [v4 1/8] iommu: Add new member capability to struct irq_remap_ops Feng Wu
2015-02-02 8:06 ` [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts Feng Wu
2015-03-23 11:57 ` Joerg Roedel
2015-03-24 2:32 ` Wu, Feng
2015-03-31 15:16 ` Joerg Roedel [this message]
2015-04-01 8:51 ` Wu, Feng
2015-02-02 8:06 ` [v4 3/8] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip Feng Wu
2015-02-02 8:07 ` [v4 4/8] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts Feng Wu
2015-02-02 8:07 ` [v4 5/8] iommu, x86: Add cap_pi_support() to detect VT-d PI capability Feng Wu
2015-02-02 8:07 ` [v4 6/8] iommu, x86: Setup Posted-Interrupts capability for Intel iommu Feng Wu
2015-02-02 8:07 ` [v4 7/8] iommu, x86: define irq_remapping_cap() Feng Wu
2015-02-02 8:07 ` [v4 8/8] iommu, x86: Properly handler PI for IOMMU hotplug Feng Wu
2015-04-02 11:28 ` [v4 0/8] Add VT-d Posted-Interrupts support - IOMMU part Joerg Roedel
2015-04-03 8:12 ` Li, ZhenHua
2015-04-07 5:02 ` Wu, Feng
-- strict thread matches above, loose matches on Subject: below --
2015-02-02 8:01 Feng Wu
2015-02-02 8:01 ` [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331151643.GF22683@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2@infradead.org \
--cc=feng.wu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).