From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182AbbCaP3y (ORCPT ); Tue, 31 Mar 2015 11:29:54 -0400 Received: from foss.arm.com ([217.140.101.70]:35725 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbbCaP3v (ORCPT ); Tue, 31 Mar 2015 11:29:51 -0400 Date: Tue, 31 Mar 2015 16:29:48 +0100 From: Will Deacon To: Joe Perches Cc: "linux-kernel@vger.kernel.org" , Catalin Marinas , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 02/25] arm64: Use bool function return values of true/false not 1/0 Message-ID: <20150331152947.GC24583@arm.com> References: <4e68cc1c7021725e529b0190ff35fa26099b57c5.1427759009.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e68cc1c7021725e529b0190ff35fa26099b57c5.1427759009.git.joe@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 12:46:00AM +0100, Joe Perches wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches > --- > arch/arm64/include/asm/dma-mapping.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h > index 6932bb5..9437e3d 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -97,7 +97,7 @@ static inline int dma_set_mask(struct device *dev, u64 mask) > static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > { > if (!dev->dma_mask) > - return 0; > + return false; > > return addr + size - 1 <= *dev->dma_mask; > } > -- > 2.1.2 Looks simple enough, I'll pick it up for 4.1. Will