From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] perf script segfault
Date: Tue, 31 Mar 2015 17:48:44 +0200 [thread overview]
Message-ID: <20150331154844.GA1812@krava.brq.redhat.com> (raw)
In-Reply-To: <20150331145739.GJ9438@kernel.org>
On Tue, Mar 31, 2015 at 11:57:39AM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> struct ordered_events *oe = &session->ordered_events;
> - struct perf_tool *tool = oe->tool;
> + struct perf_tool *tool = session->tool;
> int fd = perf_data_file__fd(session->file);
> u64 head, page_offset, file_offset, file_pos, size;
> int err, mmap_prot, mmap_flags, map_idx = 0;
> @@ -1394,6 +1407,7 @@ out:
> out_err:
> ui_progress__finish();
> perf_tool__warn_about_errors(tool, &session->evlist->stats);
> + ordered_events__warn_about_errors(&session->ordered_events);
how about just single warning function ?
perf_session__warn_about_errors(struct perf_session *session)
session has now both tool and ordered_events
jirka
next prev parent reply other threads:[~2015-03-31 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 22:51 [BUG] perf script segfault David Ahern
2015-03-30 23:45 ` Arnaldo Carvalho de Melo
2015-03-31 12:59 ` Arnaldo Carvalho de Melo
2015-03-31 13:36 ` David Ahern
2015-04-07 23:41 ` David Ahern
2015-04-07 23:49 ` David Ahern
2015-03-31 13:58 ` Jiri Olsa
2015-03-31 14:02 ` Arnaldo Carvalho de Melo
2015-03-31 14:13 ` Arnaldo Carvalho de Melo
2015-03-31 14:25 ` Jiri Olsa
2015-03-31 14:37 ` Arnaldo Carvalho de Melo
2015-03-31 14:57 ` Arnaldo Carvalho de Melo
2015-03-31 15:48 ` Jiri Olsa [this message]
2015-03-31 15:50 ` Jiri Olsa
2015-03-31 16:14 ` Arnaldo Carvalho de Melo
2015-03-31 16:17 ` Arnaldo Carvalho de Melo
2015-03-31 16:26 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331154844.GA1812@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox