From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbbCaPzx (ORCPT ); Tue, 31 Mar 2015 11:55:53 -0400 Received: from mail.kernel.org ([198.145.29.136]:53676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbCaPzu (ORCPT ); Tue, 31 Mar 2015 11:55:50 -0400 Date: Tue, 31 Mar 2015 12:55:57 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: David Ahern , linux-kernel@vger.kernel.org, Don Zickus , Joe Mario Subject: Re: [PATCH v2 1/2] perf tool: Refactor comm/tgid lookup Message-ID: <20150331155557.GK9438@kernel.org> References: <1427747758-18510-1-git-send-email-dsahern@gmail.com> <20150331143546.GD31798@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331143546.GD31798@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 31, 2015 at 04:35:46PM +0200, Jiri Olsa escreveu: > On Mon, Mar 30, 2015 at 02:35:57PM -0600, David Ahern wrote: > > Rather than parsing /proc/pid/status file one line at a time, read > > it into a buffer in one shot and search for all strings in one pass. > > > > tgid conversion also simplified -- removing the isspace walk. As > > noted by Arnaldo those are not needed for atoi == strtol calls. > > > > Signed-off-by: David Ahern > > Cc: Don Zickus > > Cc: Joe Mario > > Cc: Jiri Olsa > > Acked-by: Jiri Olsa Thanks, applied both, with Jiri's acks. - Arnaldo