From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753653AbbCaSfo (ORCPT ); Tue, 31 Mar 2015 14:35:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50638 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbbCaSfk (ORCPT ); Tue, 31 Mar 2015 14:35:40 -0400 Date: Tue, 31 Mar 2015 15:35:26 -0300 From: Eduardo Habkost To: Michael Mueller Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson , Daniel Hansel Subject: Re: [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model Message-ID: <20150331183526.GJ7031@thinpad.lan.raisama.net> References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> X-Fnord: you can see the fnord User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > This patch implements a new QMP request named 'query-cpu-model'. > It returns the cpu model of cpu 0 and its backing accelerator. > > request: > {"execute" : "query-cpu-model" } > > answer: > {"return" : {"name": "2827-ga2", "accel": "kvm" }} > > Alias names are resolved to their respective machine type and GA names > already during cpu instantiation. Thus, also a cpu model like 'host' > which is implemented as alias will return its normalized cpu model name. > > Furthermore the patch implements the following function: > > - s390_cpu_models_used(), returns true if S390 cpu models are in use > > Signed-off-by: Michael Mueller > --- [...] > +static inline char *strdup_s390_cpu_name(S390CPUClass *cc) > +{ > + return g_strdup_printf("%04x-ga%u", cc->proc.type, cc->mach.ga); > +} How exactly is this information going to be used by clients? If getting the correct type and ga values is important for them, maybe you could add them as integer fields, instead of requiring clients to parse the CPU model name? -- Eduardo