From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbbDADjm (ORCPT ); Tue, 31 Mar 2015 23:39:42 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35968 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893AbbDADjk (ORCPT ); Tue, 31 Mar 2015 23:39:40 -0400 Date: Wed, 1 Apr 2015 09:09:26 +0530 From: Sudip Mukherjee To: Eddie Kovsky Cc: gregkh@linuxfoundation.org, cristina.opriceana@gmail.com, gdonald@gmail.com, mahfouz.saif.elyazal@gmail.com, benoit.taine@lip6.fr, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8192u Make function static Message-ID: <20150401033926.GA4638@sudip-PC> References: <20150331235119.GA31450@athena> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331235119.GA31450@athena> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote: > Changing function definition to static fixes the > following warning generated by sparse: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static? some one has already done this and it has been already applied to staging-testing. regards sudip >