From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Feng Kan <fkan@apm.com>
Cc: patches@apm.com, jassisinghbrar@gmail.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] mailbox: add ACPI support for mailbox framework
Date: Wed, 1 Apr 2015 10:45:53 +0300 [thread overview]
Message-ID: <20150401074553.GV1524@lahna.fi.intel.com> (raw)
In-Reply-To: <1427836680-13008-1-git-send-email-fkan@apm.com>
On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote:
> This will add support for ACPI parsing of the mboxes attribute
> when booting with ACPI table. The client will have a attribute
> mimic the dts call "mboxes". In the ACPI case, the client will
> mark "mboxes" with the ACPI HID of the mbox it wishes to use.
>
> Name (_DSD, Package () {
> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> Package () {
> Package (2) {"mboxes", "ACPIHID"},
> }
> })
Instead of this, why not match against the DT compatible property?
Name (_HID, "PRP0001")
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package (2) {"compatible", "your-dt-compatible-string"},
}
})
This all will be done for you automatically with zero changes in the
code.
next prev parent reply other threads:[~2015-04-01 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 21:18 [PATCH] mailbox: add ACPI support for mailbox framework Feng Kan
2015-04-01 7:45 ` Mika Westerberg [this message]
2015-04-01 17:01 ` Feng Kan
2015-04-02 9:07 ` Mika Westerberg
2015-04-02 18:04 ` Feng Kan
2015-04-07 8:41 ` Mika Westerberg
2015-04-07 11:37 ` Rafael J. Wysocki
2015-04-07 14:05 ` Mika Westerberg
2015-04-07 22:58 ` Feng Kan
2015-04-10 23:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401074553.GV1524@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=fkan@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox