From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbbDALmv (ORCPT ); Wed, 1 Apr 2015 07:42:51 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:36306 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbbDALms (ORCPT ); Wed, 1 Apr 2015 07:42:48 -0400 Date: Wed, 1 Apr 2015 12:42:43 +0100 From: Lee Jones To: Kishon Vijay Abraham I Cc: Maxime Coquelin , Peter Griffin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, patrice.chotard@st.com, balbi@ti.com, devicetree@vger.kernel.org, robherring2@gmail.com Subject: Re: [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Message-ID: <20150401114243.GV9447@x1> References: <1427728632-10846-1-git-send-email-peter.griffin@linaro.org> <1427728632-10846-2-git-send-email-peter.griffin@linaro.org> <551A2D4D.1010601@ti.com> <20150331074027.GH9447@x1> <551ABD99.2000503@ti.com> <551AC37E.70503@st.com> <20150401071501.GS9447@x1> <551BA5CB.6030903@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <551BA5CB.6030903@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Apr 2015, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 01 April 2015 12:45 PM, Lee Jones wrote: > >On Tue, 31 Mar 2015, Maxime Coquelin wrote: > > > >>Hi Kishon, > >>On 03/31/2015 05:30 PM, Kishon Vijay Abraham I wrote: > >>>Maxime, > >>> > >>>On Tuesday 31 March 2015 01:10 PM, Lee Jones wrote: > >>>>On Tue, 31 Mar 2015, Kishon Vijay Abraham I wrote: > >>>> > >>>>>Hi Patrice, Maxime, > >>>>> > >>>>>On Monday 30 March 2015 08:47 PM, Peter Griffin wrote: > >>>>>>Now there are generic phy type constants declared in phy.h, > >>>>>>migrate over to > >>>>>>using them rather than defining our own. This change has > >>>>>>been done as one > >>>>>>atomic commit to be bisectable. > >>>>>> > >>>>>>Note: The values of the defines are the same, so there is no > >>>>>>ABI breakage > >>>>>>with this patch. > >>>>>> > >>>>>>Signed-off-by: Peter Griffin > >>>>>>Acked-by: Rob Herring > >>>>>>Acked-by: Lee Jones > >>>>> > >>>>>Are you okay for this patch to go via PHY tree? It modifies > >>>>>arch/arm/boot/dts > >>>>>/stih416.dtsi. > >>>> > >>>>These files need to be changed simultaneously in order to prevent > >>>>breakage during bisection and the like. I think the best bet moving > >>>>forward is to pull this into its own branch, tag it and send Maxime a > >>>>pull-request to the immutable branch. It's the best way to minimise > >>>>merge conflicts during the v4.1 merge window. > >>> > >>>okay. I still need an Ack from Maxime. > >> > >>You have my Ack. > >> > >>I haven't sent a pull request for STi DT files for v4.1 now, and it > >>is too late to send one. > >>So creating an immutable tag is not even needed in my opinion, you > >>can just take the DT patch. > > > >Kishon, > > > >I saw that you took the MAINTAINERS patch, but not this one. If it's > >because you are still unsure about it, I agree with Maxime, you can > >just take this patch without fear of conflict. > > I've took this already > https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=next&id=76fa6deabab05688a1653c2f66224be4a3c08d6a I missed that. Thanks for pointing it out. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog