Re: [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h

Lee Jones
2015-03-31T08:47:50Z

On Tue, 31 Mar 2015, Peter Griffin wrote:
> On Tue, 31 Mar 2015, Lee Jones wrote:
> > On Tue, 31 Mar 2015, Kishon Vijay Abraham I wrote:
> >
> > > Hi Patrice, Maxime,
> > >
> > > On Monday 30 March 2015 08:47 PM, Peter Griffin wrote:
> > > >Now there are generic phy type constants declared in phy.h, migrate over to
> > > >using them rather than defining our own. This change has been done as one
> > > >atomic commit to be bisectable.
> > > >
> > > >Note: The values of the defines are the same, so there is no ABI breakage
> > > >with this patch.
> > > >
> > > >Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > > >Acked-by: Rob Herring <robh@kernel.org>
> > > >Acked-by: Lee Jones <lee.jones@linaro.org>
> > >
> > > Are you okay for this patch to go via PHY tree? It modifies arch/arm/boot/dts
> > > /stih416.dtsi.
> >
> > These files need to be changed simultaneously in order to prevent
> > breakage during bisection and the like.
>
> That is why it has been authored as one atomic commit. See commit message above.

I already know you know why you did it. The comment was for Kishon.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog