From: Ralf Baechle <ralf@linux-mips.org>
To: Jonas Gorski <jogo@openwrt.org>
Cc: Florian Fainelli <florian@openwrt.org>,
Joe Perches <joe@perches.com>, Daniel Walter <dwalter@google.com>,
Linux-MIPS <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] ar7: replace mac address parsing
Date: Wed, 1 Apr 2015 17:08:48 +0200 [thread overview]
Message-ID: <20150401150848.GA27199@linux-mips.org> (raw)
In-Reply-To: <CAOiHx==91cquJ0OAf-n40HB39HbtLw-5RrxhxtsJXbTyNgit8w@mail.gmail.com>
On Wed, Apr 01, 2015 at 02:17:16PM +0200, Jonas Gorski wrote:
> for (i = 0; i < 6; i++)
> dev_addr[i] = (char2hex(mac[i * 3]) << 4) +
> char2hex(mac[i * 3 + 1]);
>
>
> So I'm tempted to say it should not cause any issues. But my sample
> size is rather small.
4.1 is still long enough out to test ...
Ralf
next prev parent reply other threads:[~2015-04-01 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 15:39 [PATCH 1/1] ar7: replace mac address parsing Daniel Walter
2014-06-24 15:48 ` Joe Perches
2014-06-24 19:26 ` Florian Fainelli
2015-04-01 12:17 ` Jonas Gorski
2015-04-01 15:08 ` Ralf Baechle [this message]
2015-04-01 18:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401150848.GA27199@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dwalter@google.com \
--cc=florian@openwrt.org \
--cc=joe@perches.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox