From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org,
airlied@gmail.com, airlied@redhat.com,
David Airlie <airlied@linux.ie>,
Rusty Russell <rusty@rustcorp.com.au>,
open list <linux-kernel@vger.kernel.org>,
"open list:VIRTIO CORE,
NET..." <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 4/4] Add virtio-vga bits.
Date: Wed, 1 Apr 2015 15:26:26 +0200 [thread overview]
Message-ID: <20150401152535-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1427894130-14228-5-git-send-email-kraxel@redhat.com>
On Wed, Apr 01, 2015 at 03:15:30PM +0200, Gerd Hoffmann wrote:
> +static void virtio_pci_kick_out_firmware_fb(struct pci_dev *pci_dev)
> +{
> + struct apertures_struct *ap;
> + bool primary;
> +
> + ap = alloc_apertures(1);
> + if (!ap)
> + return;
> +
> + ap->ranges[0].base = pci_resource_start(pci_dev, 2);
> + ap->ranges[0].size = pci_resource_len(pci_dev, 2);
I thought you mentioned it's better to switch to a different BAR
to be compatible with stdvga?
--
MST
next prev parent reply other threads:[~2015-04-01 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1427894130-14228-1-git-send-email-kraxel@redhat.com>
2015-04-01 13:15 ` [PATCH v2 1/4] break kconfig dependency loop Gerd Hoffmann
2015-04-01 13:47 ` Jani Nikula
2015-04-06 9:50 ` Paul Bolle
2015-04-06 14:27 ` Mauro Carvalho Chehab
[not found] ` <CAEG8a3+Wp-jgtwKmcBhG2gVAOP2tQ5MHuJwYe-m2HwYQRB06HQ@mail.gmail.com>
2015-04-01 15:08 ` Michael S. Tsirkin
2015-04-01 15:38 ` Gerd Hoffmann
2015-05-14 18:23 ` Mauro Carvalho Chehab
2015-04-01 13:15 ` [PATCH v2 2/4] drm_vblank_get: don't WARN_ON in case vblanks are not initialized Gerd Hoffmann
2015-04-02 13:37 ` Alex Deucher
2015-04-01 13:15 ` [PATCH v2 3/4] Add virtio gpu driver Gerd Hoffmann
2015-04-01 13:31 ` Michael S. Tsirkin
[not found] ` <CAJ+F1CK3ibbn8e1-rUY4OUJuaCt_=JmuT00Fqx4YDD9M5zJv=A@mail.gmail.com>
2015-04-07 9:41 ` Gerd Hoffmann
2015-04-01 13:15 ` [PATCH v2 4/4] Add virtio-vga bits Gerd Hoffmann
2015-04-01 13:26 ` Michael S. Tsirkin [this message]
2015-04-01 13:42 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401152535-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).