From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbDANbR (ORCPT ); Wed, 1 Apr 2015 09:31:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbbDANbQ (ORCPT ); Wed, 1 Apr 2015 09:31:16 -0400 Date: Wed, 1 Apr 2015 15:31:02 +0200 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org, airlied@gmail.com, airlied@redhat.com, David Airlie , Rusty Russell , open list , "open list:ABI/API" , "open list:VIRTIO CORE, NET..." Subject: Re: [PATCH v2 3/4] Add virtio gpu driver. Message-ID: <20150401152857-mutt-send-email-mst@redhat.com> References: <1427894130-14228-1-git-send-email-kraxel@redhat.com> <1427894130-14228-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427894130-14228-4-git-send-email-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2015 at 03:15:29PM +0200, Gerd Hoffmann wrote: > +int virtio_gpu_driver_unload(struct drm_device *dev) > +{ > + struct virtio_gpu_device *vgdev = dev->dev_private; > + > + vgdev->vqs_ready = false; Probably ok since flush below will sync all cpus, but this needs a comment I think. > + flush_work(&vgdev->ctrlq.dequeue_work); > + flush_work(&vgdev->cursorq.dequeue_work); I see there are a bunch of other work entries - don't all of them need to be flushed? > + vgdev->vdev->config->del_vqs(vgdev->vdev); > + > + virtio_gpu_modeset_fini(vgdev); > + virtio_gpu_ttm_fini(vgdev); > + virtio_gpu_free_vbufs(vgdev); > + kfree(vgdev); > + return 0; > +}