From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbDAS1k (ORCPT ); Wed, 1 Apr 2015 14:27:40 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:46322 "EHLO e18.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208AbbDAS1h (ORCPT ); Wed, 1 Apr 2015 14:27:37 -0400 Date: Wed, 1 Apr 2015 11:26:32 -0700 From: Sukadev Bhattiprolu To: Joe Perches Cc: Michael Ellerman , Paul Mackerras , peterz@infradead.org, dev@codyps.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 08/10] perf/hv24x7: Whitespace cleanup Message-ID: <20150401182632.GA4287@us.ibm.com> References: <1427766828-771-1-git-send-email-sukadev@linux.vnet.ibm.com> <1427766828-771-9-git-send-email-sukadev@linux.vnet.ibm.com> <1427771281.14276.48.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427771281.14276.48.camel@perches.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15040118-0033-0000-0000-00000045DA59 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches [joe@perches.com] wrote: | On Mon, 2015-03-30 at 18:53 -0700, Sukadev Bhattiprolu wrote: | > Fix minor whitespace damages. | | If you are going to do whitespace cleaning, | please verify the patches with scripts/checkpatch.pl --strict. Ok. Will fix up parameter alignment with the open parens in a follow on patch. | | > diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c | [] | > @@ -1077,7 +1079,6 @@ static unsigned long single_24x7_request(struct perf_event *event, u64 *count) | > } | > | > resb = &result_buffer->results[0]; | > - | > *count = be64_to_cpu(resb->elements[0].element_data[0]); | > out: | > return ret; | | Does this deletion make the code easier to read? | | It might be better just to use: | | be64 val; | ... | val = result_buffer->results[0].elements[0].element_data[0]; | *count = be64_to_cpu(val); Agree. Will include in a follow on patch. Sukadev