[slave-dma:for-linus 26/28] drivers/dma/xgene-dma.c:396:25: sparse: incorrect type in assignment (different base types)

[slave-dma:for-linus 26/28] drivers/dma/xgene-dma.c:396:25: sparse: incorrect type in assignment (different base types)

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git for-linus
head:   fe90ced9e9d7bdba75ccae83100ae656807a6261
commit: 9f2fd0dfa594d857fbdaeda523ff7a46f16567f5 [26/28] dmaengine: Add support for APM X-Gene SoC DMA engine driver
reproduce:
  # apt-get install sparse
  git checkout 9f2fd0dfa594d857fbdaeda523ff7a46f16567f5
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/dma/xgene-dma.c:396:25: sparse: incorrect type in assignment (different base types)
   drivers/dma/xgene-dma.c:396:25:    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident>
   drivers/dma/xgene-dma.c:396:25:    got restricted __le64 [usertype] <noident>
>> drivers/dma/xgene-dma.c:818:26: sparse: cast to restricted __le64
>> drivers/dma/xgene-dma.c:818:26: sparse: cast to restricted __le64
>> drivers/dma/xgene-dma.c:1626:5: sparse: symbol 'xgene_dma_init_ring_mngr' was not declared. Should it be static?
   drivers/dma/xgene-dma.c:2088:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at drivers/dma/xgene-dma.c:2087)

Please review and possibly fold the followup patch.

vim +396 drivers/dma/xgene-dma.c

   380		[ERR_DESC_SRC_INT] = "HFB reading src link address error",
   381	};
   382	
   383	static bool is_pq_enabled(struct xgene_dma *pdma)
   384	{
   385		u32 val;
   386	
   387		val = ioread32(pdma->csr_efuse + XGENE_SOC_JTAG1_SHADOW);
   388		return !(val & XGENE_DMA_PQ_DISABLE_MASK);
   389	}
   390	
   391	static void xgene_dma_cpu_to_le64(u64 *desc, int count)
   392	{
   393		int i;
   394	
   395		for (i = 0; i < count; i++)
 > 396			desc[i] = cpu_to_le64(desc[i]);
   397	}
   398	
   399	static u16 xgene_dma_encode_len(u32 len)
   400	{
   401		return (len < XGENE_DMA_MAX_BYTE_CNT) ?
   402			len : XGENE_DMA_16K_BUFFER_LEN_CODE;
   403	}
   404	

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH slave-dma] dmaengine: xgene_dma_init_ring_mngr() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 xgene-dma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c
index 2383528..aa61935 100755
--- a/drivers/dma/xgene-dma.c
+++ b/drivers/dma/xgene-dma.c
@@ -1623,7 +1623,7 @@ static void xgene_dma_init_hw(struct xgene_dma *pdma)
 		 XGENE_DMA_DEV_ID_RD(val), XGENE_DMA_MAX_CHANNEL);
 }
 
-int xgene_dma_init_ring_mngr(struct xgene_dma *pdma)
+static int xgene_dma_init_ring_mngr(struct xgene_dma *pdma)
 {
 	if (ioread32(pdma->csr_ring + XGENE_DMA_RING_CLKEN) &&
 	    (!ioread32(pdma->csr_ring + XGENE_DMA_RING_SRST)))

Re: [PATCH slave-dma] dmaengine: xgene_dma_init_ring_mngr() can be static

[Vinod Koul]

On Thu, Apr 02, 2015 at 05:50:56PM +0800, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  xgene-dma.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c
> index 2383528..aa61935 100755
> --- a/drivers/dma/xgene-dma.c
> +++ b/drivers/dma/xgene-dma.c
> @@ -1623,7 +1623,7 @@ static void xgene_dma_init_hw(struct xgene_dma *pdma)
>  		 XGENE_DMA_DEV_ID_RD(val), XGENE_DMA_MAX_CHANNEL);
>  }
>  
> -int xgene_dma_init_ring_mngr(struct xgene_dma *pdma)
> +static int xgene_dma_init_ring_mngr(struct xgene_dma *pdma)
>  {
>  	if (ioread32(pdma->csr_ring + XGENE_DMA_RING_CLKEN) &&
>  	    (!ioread32(pdma->csr_ring + XGENE_DMA_RING_SRST)))

Applied thanks
-- 
~Vinod