Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

Borislav Petkov
2015-04-02T11:21:19Z

On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote:
> So doesn't a 'nokaslr' boot option still make sense, to be able to
> debug KASLR failures and such?

That's still parsed in arch/x86/boot/compressed/aslr.c

> > + if (kaslr_enabled())
> > + pr_emerg("Kernel Offset: 0x%lx from 0x%lx (relocation range: 0x%lx-0x%lx)\n",
> > + (unsigned long)&_text - __START_KERNEL,
> > + __START_KERNEL,
> > + __START_KERNEL_map,
> > + MODULES_VADDR-1);
> > + else
> > + pr_emerg("Kernel Offset: disabled\n");
>
> Nit: curly braces for multi-line statements and so.

I guess by multi-line you mean multiple source lines...

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--