From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
mpe@ellerman.id.au, tglx@linutronix.de, rjw@rjwysocki.net,
nicolas.pitre@linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting
Date: Thu, 2 Apr 2015 14:02:56 +0200 [thread overview]
Message-ID: <20150402120256.GV23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150402104226.GB21105@gmail.com>
On Thu, Apr 02, 2015 at 12:42:27PM +0200, Ingo Molnar wrote:
> So why not use a suitable CPU_DOWN* notifier for this, instead of open
> coding it all into a random place in the hotplug machinery?
Because notifiers are crap? ;-) Its entirely impossible to figure out
what's happening to core code in hotplug. You need to go chase down and
random order notifier things.
I'm planning on taking out many of the core hotplug notifiers and hard
coding their callbacks into the hotplug code.
That way at least its clear wtf happens when.
> Also, I improved the changelog (attached below), but decided against
> applying it until these questions are cleared - please use that for
> future versions of this patch.
> Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
You forgot to fix the Fixes line ;-)
My copy has:
Fixes: 5d1638acb9f6 ("tick: Introduce hrtimer based broadcast")
next prev parent reply other threads:[~2015-04-02 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 9:29 [PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting Preeti U Murthy
2015-03-31 3:11 ` Nicolas Pitre
2015-04-02 10:42 ` Ingo Molnar
2015-04-02 11:25 ` Preeti U Murthy
2015-04-02 11:31 ` Ingo Molnar
2015-04-02 11:44 ` Preeti U Murthy
2015-04-02 12:02 ` Peter Zijlstra [this message]
2015-04-02 12:12 ` Ingo Molnar
2015-04-02 12:44 ` Preeti U Murthy
2015-04-02 12:58 ` Peter Zijlstra
2015-04-02 14:30 ` [tip:timers/core] clockevents: Fix cpu_down() " tip-bot for Preeti U Murthy
2015-04-03 10:38 ` Preeti U Murthy
2015-04-03 10:50 ` Ingo Molnar
2015-04-06 4:28 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402120256.GV23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nicolas.pitre@linaro.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox