From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbbDBOee (ORCPT ); Thu, 2 Apr 2015 10:34:34 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34249 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbbDBOe2 (ORCPT ); Thu, 2 Apr 2015 10:34:28 -0400 Date: Thu, 2 Apr 2015 16:34:24 +0200 From: Johan Hovold To: "Dr. H. Nikolaus Schaller" Cc: Johan Hovold , Marek Belisko , gregkh@linuxfoundation.org, corbet@lwn.net, linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, gta04-owner@goldelico.com Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id Message-ID: <20150402143424.GT16062@localhost> References: <1427316814-22276-1-git-send-email-marek@goldelico.com> <1427549877-7921-1-git-send-email-marek@goldelico.com> <20150330074508.GE4046@localhost> <38A4892E-80CD-4028-87DD-B4AAB4618EC5@goldelico.com> <20150330100837.GK4046@localhost> <6C4F1B47-3881-4236-8811-EA4CB5764F22@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6C4F1B47-3881-4236-8811-EA4CB5764F22@goldelico.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 04:25:50PM +0200, Dr. H. Nikolaus Schaller wrote: > >>>> But it is outdated. The parameters vendor= and product= are no longer > >>>> available since ca. 3.12 which means that documentation is lagging behind > >>>> quite some time. > >>> > >>> This is simply not true. The vendor and module parameters are still > >>> there for usbserial (i.e. the generic driver). > >>> > >>> Would you mind updating this patch to document the sysfs-method as an > >>> alternative instead? Using sysfs is preferred as that functionality can > >>> be used with any usb-serial driver and the drivers can also be compiled > >>> in. > >> > >> Hm. For me it did not work as described and therefore I searched for > >> and found the solution cited below, which appears to confirm that it does > >> not work any more. Only with these hints to use the /sys approach I > >> could make it working immediately. > >> > >> Therefore I assumed that the documentation is outdated. > >> > >> But it might also be a hidden bug with the parameter passing. > >> I had tested on 4.0-rc3. > >> > >> I can try a little more but it might be waste of time to find out why the old > >> does not work, if there is a preferred method now. > > > > Please do try to figure out if it doesn't work as we have not deprecated > > this functionality yet. It should still work. > > Good news: > > I have tried again (this time with 4.0-rc5) and was successful. I have no > clue why it did not work with my tests with 4.0-rc3. Great. > So we will edit the patch to describe > * that the sysfs method is in addition, and preferred > * and works even if driver is compiled into the kernel (which I > haven’t tested in my setup but assume it works as well) > > Ok? That should do it (and, yes, it works when the module is compiled in). Thanks, Johan