From: Borislav Petkov <bp@alien8.de>
To: Quentin Casasnovas <quentin.casasnovas@oracle.com>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH] x86/xsave: Robustify and merge macros
Date: Thu, 2 Apr 2015 18:45:15 +0200 [thread overview]
Message-ID: <20150402164515.GF3483@pd.tnic> (raw)
In-Reply-To: <20150402163340.GB14902@chrystal.uk.oracle.com>
On Thu, Apr 02, 2015 at 06:33:40PM +0200, Quentin Casasnovas wrote:
> I would personnaly add it to the non _booting() variants as well to make
> sure the alternative instructions _are_ applied, since otherwise that would
> probably cause random failures to restore the xsaveopt/xsaves context
> previously saved.
This is probably the only reason why I should keep them: so that there
are no mismatched save and restore uses. But this needs to be cleaned up
properly, maybe the two even merged. It would need more analysis at the
callsites. Definitely future work.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-04-02 16:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 13:11 [PATCH] x86/xsave: Robustify and merge macros Borislav Petkov
2015-04-02 15:52 ` Quentin Casasnovas
2015-04-02 16:12 ` Borislav Petkov
2015-04-02 16:33 ` Quentin Casasnovas
2015-04-02 16:45 ` Borislav Petkov [this message]
2015-04-03 14:06 ` Quentin Casasnovas
2015-04-03 14:14 ` Quentin Casasnovas
2015-04-03 15:23 ` Borislav Petkov
2015-04-03 15:40 ` Quentin Casasnovas
2015-04-03 17:06 ` Borislav Petkov
2015-04-03 17:33 ` Quentin Casasnovas
2015-04-03 17:48 ` Borislav Petkov
2015-04-03 20:42 ` Quentin Casasnovas
2015-04-04 7:34 ` Borislav Petkov
2015-04-04 8:36 ` Quentin Casasnovas
2015-04-04 9:25 ` Borislav Petkov
2015-04-04 10:11 ` Quentin Casasnovas
2015-04-04 10:29 ` Borislav Petkov
2015-04-04 13:32 ` Borislav Petkov
2015-04-04 13:34 ` [PATCH] x86/alternatives: Fix ALTERNATIVE_2 padding generation properly Borislav Petkov
2015-04-07 9:27 ` Quentin Casasnovas
2015-04-07 9:40 ` [tip:x86/asm] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402164515.GF3483@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=quentin.casasnovas@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox