From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sasha Levin <sasha.levin@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
maninder1.s@samsung.com, tglx@linutronix.de,
Yogesh Narayan Gaur <yn.gaur@samsung.com>,
AJEET YADAV <ajeet.y@samsung.com>
Subject: Re: restart_syscall: use freezable blocking call
Date: Thu, 2 Apr 2015 13:34:04 -0400 [thread overview]
Message-ID: <20150402173404.GV9974@htj.duckdns.org> (raw)
In-Reply-To: <20150402172513.GE23123@twins.programming.kicks-ass.net>
On Thu, Apr 02, 2015 at 07:25:13PM +0200, Peter Zijlstra wrote:
> On Thu, Apr 02, 2015 at 12:03:08PM -0400, Sasha Levin wrote:
> > It's not correct.
>
> Yay for lockdep ;-)
>
> > [ 0.645644] debug_check_no_locks_held (kernel/locking/lockdep.c:4178)
>
> Should we also have that call in freezer_do_not_count() ?
I think conerting a general scheduling function like
schedule_hrtimeout to do freezable sleeps blindly is a pretty bad
idea. This must be determined per specific sleep site.
Thanks.
--
tejun
prev parent reply other threads:[~2015-04-02 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 11:07 restart_syscall: use freezable blocking call Maninder Singh
2015-03-30 22:43 ` Andrew Morton
2015-03-30 23:39 ` Rafael J. Wysocki
2015-03-31 15:07 ` Peter Zijlstra
2015-04-02 16:03 ` Sasha Levin
2015-04-02 17:25 ` Peter Zijlstra
2015-04-02 17:34 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402173404.GV9974@htj.duckdns.org \
--to=tj@kernel.org \
--cc=ajeet.y@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=yn.gaur@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox