Re: [PATCH] i2c: cadence: Handling Slave monitor mode

Wolfram Sang
2015-03-27T15:36:49Z

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Tue, Mar 17, 2015 at 09:48:15PM +0530, Nava kishore Manne wrote:
> In slave monitor mode, the I2C interface is set up as a master and
> continues to attempt a transfer to a particular slave until the
> slave device responds with an ACK.
>
> Added this feature for zero length transfers enable the controller
> for slave monitor interrupt and get the status. Disable the slave
> monitor mode feature upon successful handling.
>
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> Acked-by: Harini Katakam <harinik@xilinx.com>

I am not sure this is going to work.

How often is this access tried when there is no device? It should be
tried only once.

Those 0byte messages can be read or write, so transferring one bit, one
could say. I assume this one can only read? (which is not a show-stopper
but the cases should be handled)