From: Marcelo Tosatti <mtosatti@redhat.com>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: "'Luiz Capitulino'" <lcapitulino@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: kernel/timer: avoid spurious ksoftirqd wakeups
Date: Thu, 2 Apr 2015 17:29:54 -0300 [thread overview]
Message-ID: <20150402202954.GA8957@amt.cnet> (raw)
In-Reply-To: <042701d06cf5$b243a7b0$16caf710$@alibaba-inc.com>
On Thu, Apr 02, 2015 at 11:32:49AM +0800, Hillf Danton wrote:
> > --- a/kernel/time/tick-sched.c
> > +++ b/kernel/time/tick-sched.c
> > @@ -568,6 +568,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
> > unsigned long rcu_delta_jiffies;
> > struct clock_event_device *dev = __this_cpu_read(tick_cpu_device.evtdev);
> > u64 time_delta;
> > + bool raise_softirq;
> >
> s/raise_softirq/raise_softirq = false/ ?
Not necessary, variable is initialized before being used.
> > time_delta = timekeeping_max_deferment();
> >
next prev parent reply other threads:[~2015-04-02 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <042301d06cf5$2ec7ae90$8c570bb0$@alibaba-inc.com>
2015-04-02 3:32 ` kernel/timer: avoid spurious ksoftirqd wakeups Hillf Danton
2015-04-02 20:29 ` Marcelo Tosatti [this message]
2015-04-02 1:44 Marcelo Tosatti
2015-04-02 13:58 ` Rik van Riel
2015-04-02 20:53 ` Marcelo Tosatti
2015-04-02 14:59 ` Frederic Weisbecker
2015-04-02 21:08 ` Marcelo Tosatti
2015-04-06 23:34 ` Frederic Weisbecker
2015-04-06 23:51 ` Marcelo Tosatti
2015-04-07 20:17 ` Frederic Weisbecker
2015-04-07 22:29 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402202954.GA8957@amt.cnet \
--to=mtosatti@redhat.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox