From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752586AbbDCJUW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 05:20:22 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:23617 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750922AbbDCJUS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 05:20:18 -0400
Date: Fri, 3 Apr 2015 12:19:55 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, seanm@seanm.ca, devel@driverdev.osuosl.org,
        mdcasey@chabloom.com, aysemelikeyurtoglu@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8192e: Change printk statements in
 rtllib_tx.c to use netdev_dev
Message-ID: <20150403091955.GO10964@mwanda>
References: <1428034880-12672-1-git-send-email-xerofoify@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428034880-12672-1-git-send-email-xerofoify@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
>  	   ((!ieee->softmac_data_hard_start_xmit &&
>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",


This should be netdev_warn().  There are a few other similar places.

regards,
dan carpenter