From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Witos <pwitos@gmail.com>
Cc: devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
trivial@kernel.org, speakup@linux-speakup.org,
linux-kernel@vger.kernel.org,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
Date: Fri, 3 Apr 2015 13:42:02 +0200 [thread overview]
Message-ID: <20150403114202.GA30572@kroah.com> (raw)
In-Reply-To: <20150327202942.GA9858@witos-linux>
On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote:
> Changed bool to u8.
>
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
Your From: email line and signed-off-by: line names do not match, so I
can't take this patch :(
Please fix up and resend.
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
> #define PRESSED 1
> #define RELEASED 0
>
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);
What is this fixing? Why can't we have a bool as a per-cpu variable?
We are only writing true or false to it.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-03 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 20:29 [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Witos
2015-04-03 11:42 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-27 20:36 Witos
2015-03-28 6:26 ` Sudip Mukherjee
2015-03-28 7:57 ` Piotr Witosławski
2015-03-30 6:19 ` Sudip Mukherjee
2015-04-03 11:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403114202.GA30572@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=pwitos@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox