From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbbDCLmK (ORCPT ); Fri, 3 Apr 2015 07:42:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39659 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbbDCLmH (ORCPT ); Fri, 3 Apr 2015 07:42:07 -0400 Date: Fri, 3 Apr 2015 13:42:02 +0200 From: Greg Kroah-Hartman To: Witos Cc: devel@driverdev.osuosl.org, Kirk Reiser , trivial@kernel.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Samuel Thibault , Chris Brannon Subject: Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Message-ID: <20150403114202.GA30572@kroah.com> References: <20150327202942.GA9858@witos-linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150327202942.GA9858@witos-linux> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote: > Changed bool to u8. > > Signed-off-by: Piotr Witoslawski Your From: email line and signed-off-by: line names do not match, so I can't take this patch :( Please fix up and resend. > --- > drivers/staging/speakup/fakekey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c > index 4299cf4..3dfb6bd 100644 > --- a/drivers/staging/speakup/fakekey.c > +++ b/drivers/staging/speakup/fakekey.c > @@ -28,7 +28,7 @@ > #define PRESSED 1 > #define RELEASED 0 > > -static DEFINE_PER_CPU(bool, reporting_keystroke); > +static DEFINE_PER_CPU(u8, reporting_keystroke); What is this fixing? Why can't we have a bool as a per-cpu variable? We are only writing true or false to it. thanks, greg k-h