From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbbDCNku (ORCPT ); Fri, 3 Apr 2015 09:40:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40981 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbbDCNks (ORCPT ); Fri, 3 Apr 2015 09:40:48 -0400 Date: Fri, 3 Apr 2015 15:40:42 +0200 From: "gregkh@linuxfoundation.org" To: "Dhere, Chaitanya (C.)" Cc: "navin.patidar@gmail.com" , "vthakkar1994@gmail.com" , "tapaswenipathak@gmail.com" , "dan.carpenter@oracle.com" , "abelmoyo.ab@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup Message-ID: <20150403134042.GA31251@kroah.com> References: <20150330151119.GA9797@chaitanya-Ideapad-Z560> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150330151119.GA9797@chaitanya-Ideapad-Z560> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 03:11:25PM +0000, Dhere, Chaitanya (C.) wrote: > This change was detected with the help of coccinelle tool. > It performs the same function as kzalloc amd memcpy. > > Signed-off-by: Chaitanya Dhere Your From: line and this line don't match :( > --- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > index 86d955f..07ae6cf 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > @@ -5431,15 +5431,14 @@ u8 set_tx_beacon_cmd(struct adapter *padapter) > goto exit; > } > > - ptxBeacon_parm = kzalloc(sizeof(struct wlan_bssid_ex), GFP_KERNEL); > + ptxBeacon_parm = kmemdup(&(pmlmeinfo->network), > + sizeof(struct wlan_bssid_ex), GFP_KERNEL); > if (ptxBeacon_parm == NULL) { > kfree(ph2c); > res = _FAIL; > goto exit; > } > > - memcpy(ptxBeacon_parm, &(pmlmeinfo->network), sizeof(struct wlan_bssid_ex)); > - > len_diff = update_hidden_ssid(ptxBeacon_parm->IEs+_BEACON_IE_OFFSET_, > ptxBeacon_parm->IELength-_BEACON_IE_OFFSET_, > pmlmeinfo->hidden_ssid_mode); > -- > 1.9.1 This patch fails to apply for some odd reason, the patch seems corrupted. Please look into your email client settings and try it again. thanks, greg k-h