From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753041AbbDCOFU (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 10:05:20 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40640 "EHLO
	out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752720AbbDCOFR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 10:05:17 -0400
X-Sasl-enc: H0uzgwUWHQWab1LjBC1MmEXZGRdkWbriObR83pTE66ur 1428069913
Date: Fri, 3 Apr 2015 16:05:10 +0200
From: Greg KH <greg@kroah.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the char-misc tree
Message-ID: <20150403140510.GA12376@kroah.com>
References: <20150327184835.6b214809@canb.auug.org.au>
 <18153784.217855.1427830545058.open-xchange@webmail.nmp.proximus.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18153784.217855.1427830545058.open-xchange@webmail.nmp.proximus.be>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 31, 2015 at 09:35:45PM +0200, Fabian Frederick wrote:
> 
> 
> > On 27 March 2015 at 08:48 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> >
> > Hi all,
> >
> > After merging the char-misc tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> >
> > In file included from include/linux/module.h:17:0,
> >                  from drivers/uio/uio_pdrv_genirq.c:21:
> > include/linux/moduleparam.h:326:22: warning: initialization discards 'const'
> > qualifier from pointer target type
> >   static const struct kparam_string __param_string_##name  \
> >                       ^
> > drivers/uio/uio_pdrv_genirq.c:260:1: note: in expansion of macro
> > 'module_param_string'
> >  module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> >  ^
> >
> > Introduced by commit 4d8beff2ae07 ("uio: constify of_device_id array").
> 
> Hi Stephen,
> 
> Absolutely, my patch is wrong ; comment below explains struct is filled
> afterwards.Sorry.
> Greg, should I send you a revert or maybe we could standardize that driver ? (it
> seems it's the only one to work that way).
> 
> static const struct of_device_id uio_of_genirq_match[] = {
>         { /* This is filled with module_parm */ },
>         { /* Sentinel */ },
> };

A revert would be great, and then work to fix it "correctly" so we can
make it constant would be wonderful.  But I don't know how you would do
that at first glance.

I'll just go revert the patch now, thanks.

thanks,

greg k-h