From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] perf tools: unify perf_event_attr printing
Date: Fri, 3 Apr 2015 13:14:38 -0300 [thread overview]
Message-ID: <20150403161438.GC2500@redhat.com> (raw)
In-Reply-To: <20150403161147.GB2500@redhat.com>
Em Fri, Apr 03, 2015 at 01:11:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Apr 02, 2015 at 01:59:34PM +0200, Peter Zijlstra escreveu:
> > On Thu, Apr 02, 2015 at 12:01:53PM +0300, Adrian Hunter wrote:
> > > But personally I think the "include" approach is too ugly. I would just
> > > add a function instead. Something like:
> >
> > You've not stared at the kernel tracepoint code long enough ;-)
> >
> > Something like so then?
>
> Ok, this one seems to have gotten acks from Ingo, Jiri and Adrian, but
> doesn't apply because it needs that clock_id one first, searching the
> situation of that part...
Hey Peter, would you be so kind and resubmit this (at least) two part
series? I.e. the first one adding the clockid and the second, with the
consolidation of the perf_event_attr printing?
- Arnaldo
next prev parent reply other threads:[~2015-04-03 16:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-34f439278cef7b1177f8ce24f9fc81dfc6221d3b@git.kernel.org>
2015-03-27 14:32 ` [PATCH] perf, record: Add clockid parameter Peter Zijlstra
2015-03-27 17:11 ` David Ahern
2015-03-27 17:20 ` Peter Zijlstra
2015-03-27 17:35 ` David Ahern
2015-03-27 20:15 ` Arnaldo Carvalho de Melo
2015-03-27 21:59 ` Peter Zijlstra
2015-03-27 22:37 ` Stephane Eranian
2015-03-28 7:55 ` Peter Zijlstra
2015-03-30 1:00 ` David Ahern
2015-03-30 8:24 ` Peter Zijlstra
2015-03-30 17:11 ` David Ahern
2015-03-30 9:17 ` Peter Zijlstra
2015-03-30 17:17 ` David Ahern
2015-03-30 19:32 ` Peter Zijlstra
2015-03-30 19:39 ` David Ahern
2015-03-30 17:24 ` David Ahern
2015-03-30 19:33 ` Peter Zijlstra
2015-03-30 19:41 ` David Ahern
2015-03-30 19:43 ` Stephane Eranian
2015-03-31 8:19 ` Peter Zijlstra
2015-03-31 10:46 ` [RFC][PATCH] perf tools: unify perf_event_attr printing Peter Zijlstra
2015-04-01 16:26 ` Peter Zijlstra
2015-04-01 16:52 ` Jiri Olsa
2015-04-02 9:01 ` Adrian Hunter
2015-04-02 11:59 ` Peter Zijlstra
2015-04-02 12:54 ` Adrian Hunter
2015-04-03 16:11 ` Arnaldo Carvalho de Melo
2015-04-03 16:14 ` Arnaldo Carvalho de Melo [this message]
2015-04-02 8:12 ` Ingo Molnar
2015-04-02 22:28 ` Arnaldo Carvalho de Melo
2015-04-02 9:19 ` Jiri Olsa
2015-03-30 17:33 ` [PATCH] perf, record: Add clockid parameter David Ahern
2015-03-30 19:34 ` Peter Zijlstra
2015-03-30 19:46 ` David Ahern
2015-03-27 23:07 ` Stephane Eranian
2015-03-27 16:31 ` [tip:perf/timer] perf: Add per event clockid support Stephane Eranian
2015-03-27 16:35 ` Peter Zijlstra
2015-03-27 16:52 ` Stephane Eranian
2015-03-27 16:57 ` Peter Zijlstra
2015-03-27 17:00 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403161438.GC2500@redhat.com \
--to=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).