From: Greg KH <gregkh@linuxfoundation.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
seanm@seanm.ca, devel@driverdev.osuosl.org, mdcasey@chabloom.com,
aysemelikeyurtoglu@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev
Date: Fri, 3 Apr 2015 19:05:59 +0200 [thread overview]
Message-ID: <20150403170559.GA20260@kroah.com> (raw)
In-Reply-To: <5AA36D09-459F-4D3C-A8C3-C39EF1F4887B@gmail.com>
On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>
>
> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> >net_device *dev)
> >> IEEE_SOFTMAC_TX_QUEUE)) ||
> >> ((!ieee->softmac_data_hard_start_xmit &&
> >> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> - printk(KERN_WARNING "%s: No xmit handler.\n",
> >> + netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >
> >
> >This should be netdev_warn(). There are a few other similar places.
> >
> >regards,
> >dan carpenter
> My bad will send in a v2 fixing this.
Please don't, I'm not going to be taking patches from you any _year_
soon.
sorry,
greg k-h
next prev parent reply other threads:[~2015-04-03 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1428034880-12672-1-git-send-email-xerofoify@gmail.com>
2015-04-03 9:19 ` [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev Dan Carpenter
[not found] ` <5AA36D09-459F-4D3C-A8C3-C39EF1F4887B@gmail.com>
2015-04-03 17:05 ` Greg KH [this message]
[not found] ` <B4B2C165-9CC1-42A2-A78C-A22166ECB7A9@gmail.com>
2015-04-03 18:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403170559.GA20260@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdcasey@chabloom.com \
--cc=seanm@seanm.ca \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox