Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

[Dan Carpenter]

> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
>  	   ((!ieee->softmac_data_hard_start_xmit &&
>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",


This should be netdev_warn().  There are a few other similar places.

regards,
dan carpenter

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

[Greg KH]

On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
> 
> 
> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> >net_device *dev)
> >>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
> >>  	   ((!ieee->softmac_data_hard_start_xmit &&
> >>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> >> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >
> >
> >This should be netdev_warn().  There are a few other similar places.
> >
> >regards,
> >dan carpenter
> My bad will send in a v2 fixing this. 

Please don't, I'm not going to be taking patches from you any _year_
soon.

sorry,

greg k-h

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

[Greg KH]

On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote:
> 
> 
> On April 3, 2015 1:05:59 PM EDT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
> >> 
> >> 
> >> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter
> ><dan.carpenter@oracle.com> wrote:
> >> >
> >> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,
> >struct
> >> >net_device *dev)
> >> >>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
> >> >>  	   ((!ieee->softmac_data_hard_start_xmit &&
> >> >>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> >> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> >> >> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >> >
> >> >
> >> >This should be netdev_warn().  There are a few other similar places.
> >> >
> >> >regards,
> >> >dan carpenter
> >> My bad will send in a v2 fixing this. 
> >
> >Please don't, I'm not going to be taking patches from you any _year_
> >soon.
> >
> >sorry,
> >
> >greg k-h
> Very well then I guess you seem to not trust me no matter how hard I
> try.  Therefore I will avoid helping out in any subsystems you are a
> maintainer of. 

You have not tried at all.  You submit patches that don't even apply
(like this one), are incorrect, or wrong in some other way.

You activly take up the time and energy of people who are contributing
to the kernel, that is why you were banned from vger.kernel.org.  You
also, when offered a way to learn and redeem yourself, ignored it, and
did something else.

What would you do with someone like youself if you were in our shoes?

back into my kill-file you go...

greg k-h