From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbbDCRGJ (ORCPT ); Fri, 3 Apr 2015 13:06:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44843 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbbDCRGG (ORCPT ); Fri, 3 Apr 2015 13:06:06 -0400 Date: Fri, 3 Apr 2015 19:05:59 +0200 From: Greg KH To: Nicholas Krause Cc: Dan Carpenter , seanm@seanm.ca, devel@driverdev.osuosl.org, mdcasey@chabloom.com, aysemelikeyurtoglu@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev Message-ID: <20150403170559.GA20260@kroah.com> References: <1428034880-12672-1-git-send-email-xerofoify@gmail.com> <20150403091955.GO10964@mwanda> <5AA36D09-459F-4D3C-A8C3-C39EF1F4887B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5AA36D09-459F-4D3C-A8C3-C39EF1F4887B@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: > > > On April 3, 2015 5:19:55 AM EDT, Dan Carpenter wrote: > > > >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct > >net_device *dev) > >> IEEE_SOFTMAC_TX_QUEUE)) || > >> ((!ieee->softmac_data_hard_start_xmit && > >> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) { > >> - printk(KERN_WARNING "%s: No xmit handler.\n", > >> + netdev_info(ieee->dev, "%s: No xmit handler.\n", > > > > > >This should be netdev_warn(). There are a few other similar places. > > > >regards, > >dan carpenter > My bad will send in a v2 fixing this. Please don't, I'm not going to be taking patches from you any _year_ soon. sorry, greg k-h