From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753235AbbDCS1t (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 14:27:49 -0400
Received: from sauhun.de ([89.238.76.85]:36146 "EHLO pokefinder.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753204AbbDCS1o (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 14:27:44 -0400
Date: Fri, 3 Apr 2015 20:28:23 +0200
From: Wolfram Sang <wsa@the-dreams.de>
To: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/i2c/i2c-core.c: Fix sparse warning
Message-ID: <20150403182822.GC1298@katana>
References: <20150403025338.GA18595@Caladan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd"
Content-Disposition: inline
In-Reply-To: <20150403025338.GA18595@Caladan>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--i7F3eY7HS/tUJxUd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> -	u8 addr = (msg->addr << 1) | !!(msg->flags & I2C_M_RD);
> +	u8 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) != 0);

I prefer !! as an idiom for "bit to bool".

Thanks,

   Wolfram


--i7F3eY7HS/tUJxUd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVHtvGAAoJEBQN5MwUoCm21FcQALWpvJaHemccxM8O0RuuOpK1
lV61Pj3E42v8Q6Kt5l6np9xi6YU67gAqD+ky+mwyh4j0uoVufFeblbe1buda+ZP1
bY1VcvUZzYW4V63JEVCzyHvnp1gVpt/ChzJkolPyry/uwJNWYGy2q3OLu/4gtQ1n
GONrzS1Wk0J9SczeYiqtKuziBjbk9SRGLEwySfx2GrKX7WsH4+rnh8QflGycOME5
Cn3UIylu4dsErLvrfDLnw1BKgvDN40hkbxbEVpWXvxBDXNBzblljetAof5RFlmEd
EezkYE9VtF4btwy8UAqcI1s+UHUvJoj87tBP6N2k6zhfsbVqx+xagHe6+7dPA3YI
cc1mKdJ8kfIT7ifkaVhA672QJZF/X/V72Iz2SXSHAL6+681SZnB6OvnPUnzj7zUZ
nRpUuab3Aq0/KwZ+U0lT5INsGizRkEnfR2LJKSRdhTAgL2H/n9i2uoirHg//36mE
pHqyfptz0M2EMeMiV6Xhxq2I7TQ9ERu0NiZBO/Pe/6AoJU7YAgM3THJ6kKZElQYt
9o37ctDdoMixito1ZH2+jF61UYQhCbOB4dyozur5dr/xfkyrTR8LQg2wnEcciWjQ
/war04r+zk5YY6pKzHJb87qlq5E806WrGKMYGS4ynvZ1m4cXs/WRU8sRdu3Ig749
xbIWeA8nCKhN0vbnffI/
=g8cg
-----END PGP SIGNATURE-----

--i7F3eY7HS/tUJxUd--