From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753401AbbDCTqM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Apr 2015 15:46:12 -0400
Received: from sauhun.de ([89.238.76.85]:36474 "EHLO pokefinder.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753209AbbDCTpy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Apr 2015 15:45:54 -0400
Date: Fri, 3 Apr 2015 21:46:26 +0200
From: Wolfram Sang <wsa@the-dreams.de>
To: Andrey Danin <danindrey@mail.ru>
Cc: devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, ac100@lists.launchpad.net,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Julian Andres Klode <jak@jak-linux.org>,
        Marc Dietrich <marvin24@gmx.de>
Subject: Re: [PATCH v2 1/4] i2c: tegra: implement slave mode
Message-ID: <20150403194626.GB2016@katana>
References: <1427745615-5428-1-git-send-email-danindrey@mail.ru>
 <1427745615-5428-2-git-send-email-danindrey@mail.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW"
Content-Disposition: inline
In-Reply-To: <1427745615-5428-2-git-send-email-danindrey@mail.ru>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--b5gNqxB1S1yM7hjW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +static void tegra_i2c_slave_write(struct tegra_i2c_dev *i2c_dev, u32 val)
> +{
> +	i2c_writel(i2c_dev, val, I2C_SL_RCVD);
> +
> +	/*
> +	 * TODO: A correct fix needs to be found for this.
> +	 *
> +	 * We experience less incomplete messages with this delay than without
> +	 * it, but we don't know why. Help is appreciated.
> +	 */

Uh oh. So I assume this is another reason for staging?

> +	if (!i2c_dev->slave || !i2c_dev->slave->slave_cb)
> +		return -EINVAL;

The core checks for slave_cb being valid.

> +		i2c_slave_event(i2c_dev->slave, I2C_SLAVE_STOP, &dummy);

You could use value here, too, or?

> +	if (!tegra_i2c_slave_isr(irq, i2c_dev))
> +		return IRQ_HANDLED;

Minor nit: I'd prefer == 0 here, since it reads "if not slave_isr return
handled".

> +	if (slave->addr > 0x7F)
> +		addr2 = (slave->addr >> 7) | I2C_SL_ADDR2_TEN_BIT_MODE;

Nope. There are 10 bit encodings of addresses 0x000-0x07f, too. So, you
need to check for the flag (slave->flags & I2C_CLIENT_TEN).


--b5gNqxB1S1yM7hjW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVHu4SAAoJEBQN5MwUoCm2PUEQAIxJZ/wIXpg8wHVeqEBNcFxx
I6JTL0zOs5vNHqXef4vxjyXXzpnrPYp1wB2fqCDYsAN94d0msEven4knlxPZLT1b
hV3hRmVwnsT0tIyhMoVPvva2MWFB5dwm6tDwy9h6MkEbqKfsjcJ5EygTEHfnX2MD
pEeppoMYZjo/ABkKkSdPPGrDggxEXekShxMEsjXKtn6qMglEJHBB4U5oS/J48gFP
9+XqVJRqIQw2D9azEUJzSEYZ1Z8ouVjelBlvqL6WOwqr7E3IbE+RweYkZah8o5GD
vnKNpoNMzIY8AQ67WHJ/z+dge7oJtm5muTIdD72AEnOqo1aO7yTbljGzFqkrc5UK
Os7YzlCQGAxiU83+xjYKpa3RleBDan0JqWiaB2StOcZuFeSe9XJqJ2i7cES8guuU
YqXjWvcTzBc3f0zyF6qjcOpzFUWapMycmzZ8vamsmVN1UnN7ypjcKrpsPP60vy/X
g7EW2CL2pbA+bwDgvIPj7Cb3dMs+s2E4l/bMtPVbfDGq/vRnhWsO3Sim4kk3eGbt
+JTS8y2HYIfxOShpR5HHvDBqkcYgp2P4iHTXofKn3VG+YJjxTfKQBjUlP80XScsz
glaojH0/PzmFEiHgmuQD2/HKu3Xu/46LKxcEEcS32cURJNW5gU6yNRHLAv4s1J7z
q0JmaYqBo5B/F7u8Q8bk
=tgej
-----END PGP SIGNATURE-----

--b5gNqxB1S1yM7hjW--