From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: balbi@ti.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin
Date: Sat, 4 Apr 2015 11:54:44 +0200 [thread overview]
Message-ID: <20150404095444.GA17800@kroah.com> (raw)
In-Reply-To: <BLU436-SMTP87E08866A9ADD372EC627BB9F10@phx.gbl>
On Sat, Apr 04, 2015 at 05:51:21AM +0800, Chen Gang wrote:
> Under blackfin, only bf527, bf548 and bf609 may use musb. The related
> error with allmodconfig:
>
> CC [M] drivers/usb/misc/trancevibrator.o
> In file included from drivers/usb/musb/musb_core.h:70:0,
> from drivers/usb/musb/musb_core.c:103:
> drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select':
> drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function)
> #define MUSB_INDEX USB_OFFSET(USB_INDEX) /* 8 bit */
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Why not fix the root cause and provide this symbol on blackfin? There's
no specific reason why it shouldn't be able to be built on this
platform.
It's better to make platforms properly build everything, patches like
this just make things messier and harder to maintain.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-04 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 21:51 [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin Chen Gang
2015-04-03 22:03 ` Richard Weinberger
2015-04-03 22:24 ` Chen Gang
2015-04-04 9:54 ` Greg Kroah-Hartman [this message]
2015-04-04 22:33 ` Chen Gang
2015-04-05 8:29 ` Greg Kroah-Hartman
2015-04-05 15:32 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150404095444.GA17800@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox