From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489AbbDDJyu (ORCPT ); Sat, 4 Apr 2015 05:54:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52791 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbDDJys (ORCPT ); Sat, 4 Apr 2015 05:54:48 -0400 Date: Sat, 4 Apr 2015 11:54:44 +0200 From: Greg Kroah-Hartman To: Chen Gang Cc: balbi@ti.com, "linux-kernel@vger.kernel.org" , linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin Message-ID: <20150404095444.GA17800@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 04, 2015 at 05:51:21AM +0800, Chen Gang wrote: > Under blackfin, only bf527, bf548 and bf609 may use musb. The related > error with allmodconfig: > > CC [M] drivers/usb/misc/trancevibrator.o > In file included from drivers/usb/musb/musb_core.h:70:0, > from drivers/usb/musb/musb_core.c:103: > drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select': > drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function) > #define MUSB_INDEX USB_OFFSET(USB_INDEX) /* 8 bit */ > ^ > > Signed-off-by: Chen Gang Why not fix the root cause and provide this symbol on blackfin? There's no specific reason why it shouldn't be able to be built on this platform. It's better to make platforms properly build everything, patches like this just make things messier and harder to maintain. thanks, greg k-h